Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 8822013: Adding ChromeOS Photo Editor user actions (Closed)

Created:
9 years ago by Vladislav Kaznacheev
Modified:
9 years ago
Reviewers:
petkov, Ilya Sherman
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

Adding ChromeOS Photo Editor user actions This is to support http://codereview.chromium.org/8819013/ BUG=chromium-os:23803 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113380

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated a comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M chrome/tools/chromeactions.txt View 4 chunks +7 lines, -0 lines 0 comments Download
M chrome/tools/extract_actions.py View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Vladislav Kaznacheev
Please review this small patch. Thanks, Vlad
9 years ago (2011-12-06 15:28:53 UTC) #1
Ilya Sherman
LGTM http://codereview.chromium.org/8822013/diff/1/chrome/tools/extract_actions.py File chrome/tools/extract_actions.py (right): http://codereview.chromium.org/8822013/diff/1/chrome/tools/extract_actions.py#newcode227 chrome/tools/extract_actions.py:227: """Add actions reported by extensions via chrome.experimental.metrics API. ...
9 years ago (2011-12-06 22:01:17 UTC) #2
Vladislav Kaznacheev
http://codereview.chromium.org/8822013/diff/1/chrome/tools/extract_actions.py File chrome/tools/extract_actions.py (right): http://codereview.chromium.org/8822013/diff/1/chrome/tools/extract_actions.py#newcode227 chrome/tools/extract_actions.py:227: """Add actions reported by extensions via chrome.experimental.metrics API. On ...
9 years ago (2011-12-07 11:18:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kaznacheev@chromium.org/8822013/6002
9 years ago (2011-12-07 11:18:58 UTC) #4
commit-bot: I haz the power
9 years ago (2011-12-07 12:18:54 UTC) #5
Change committed as 113380

Powered by Google App Engine
This is Rietveld 408576698