Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 8822010: mac: use the preprocessor for the mac header (Closed)

Created:
9 years ago by ensonic
Modified:
9 years ago
CC:
chromium-reviews, Paweł Hajdan Jr., sadrul, brettw-cc_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

mac: use the preprocessor for the mac header The mac header is using conditional compilation to become neutral for other platforms. Unfortunately it won't work for all gyp backends, as the gyp file is removing the header from the sources for non mac platforms. Better use conditionals in the few places where we use it. That also spares us to explain the hack. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113202

Patch Set 1 #

Patch Set 2 : Revert "mac: use the preprocessor for the mac header" #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M base/message_pump_libevent.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download
M base/shared_memory_unittest.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
ensonic
9 years ago (2011-12-06 13:54:03 UTC) #1
ensonic
9 years ago (2011-12-06 13:55:12 UTC) #2
M-A Ruel
lgtm
9 years ago (2011-12-06 14:05:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ensonic@google.com/8822010/1
9 years ago (2011-12-06 14:05:36 UTC) #4
commit-bot: I haz the power
Change committed as 113202
9 years ago (2011-12-06 15:09:57 UTC) #5
ensonic
On 2011/12/06 15:09:57, I haz the power (commit-bot) wrote: > Change committed as 113202 So ...
9 years ago (2011-12-06 15:52:32 UTC) #6
M-A Ruel
On 2011/12/06 15:52:32, ensonic wrote: > just those two include parts remained, as in the ...
9 years ago (2011-12-06 17:01:21 UTC) #7
John Grabowski
9 years ago (2011-12-06 18:49:43 UTC) #8
Thx for the clear explanation in the CL description.

Powered by Google App Engine
This is Rietveld 408576698