Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8822009: Not selecting first entry in the "File save" dialog. (Closed)

Created:
9 years ago by SeRya
Modified:
9 years ago
CC:
chromium-reviews, rginda+watch_chromium.org, arv (Not doing code reviews), achuith+watch_chromium.org
Visibility:
Public.

Description

Not selecting first entry in the "File save" dialog. TEST=None BUG=chromium-os:23767 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113214

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -44 lines) Patch
M chrome/browser/resources/file_manager/js/file_manager.js View 1 8 chunks +32 lines, -44 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
SeRya
9 years ago (2011-12-06 13:26:05 UTC) #1
Vladislav Kaznacheev
http://codereview.chromium.org/8822009/diff/1/chrome/browser/resources/file_manager/js/file_manager.js File chrome/browser/resources/file_manager/js/file_manager.js (right): http://codereview.chromium.org/8822009/diff/1/chrome/browser/resources/file_manager/js/file_manager.js#newcode2665 chrome/browser/resources/file_manager/js/file_manager.js:2665: if (opt_callback) Did you mean opt_action?
9 years ago (2011-12-06 13:46:28 UTC) #2
SeRya
http://codereview.chromium.org/8822009/diff/1/chrome/browser/resources/file_manager/js/file_manager.js File chrome/browser/resources/file_manager/js/file_manager.js (right): http://codereview.chromium.org/8822009/diff/1/chrome/browser/resources/file_manager/js/file_manager.js#newcode2665 chrome/browser/resources/file_manager/js/file_manager.js:2665: if (opt_callback) On 2011/12/06 13:46:28, Vladislav Kaznacheev wrote: > ...
9 years ago (2011-12-06 15:02:10 UTC) #3
Vladislav Kaznacheev
lgtm
9 years ago (2011-12-06 15:30:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/serya@chromium.org/8822009/4001
9 years ago (2011-12-06 15:30:51 UTC) #5
commit-bot: I haz the power
9 years ago (2011-12-06 16:32:23 UTC) #6 
Change committed as 113214

Powered by Google App Engine
This is Rietveld 408576698