Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(617)

Issue 8822008: Elide write barriers and remove some heap_object->GetHeap() calls on (Closed)

Created:
9 years ago by Erik Corry
Modified:
9 years ago
CC:
v8-dev
Visibility:
Public.

Description

Elide write barriers and remove some heap_object->GetHeap() calls on Smi write barriers. Committed: http://code.google.com/p/v8/source/detail?r=10175

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -29 lines) Patch
M src/heap-inl.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/objects.cc View 2 chunks +17 lines, -4 lines 0 comments Download
M src/objects-inl.h View 18 chunks +42 lines, -24 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Erik Corry
9 years ago (2011-12-06 11:59:20 UTC) #1
Vyacheslav Egorov (Chromium)
lgtm if it helps
9 years ago (2011-12-06 12:45:29 UTC) #2
Erik Corry
9 years ago (2011-12-06 13:00:07 UTC) #3
I reverted the objects-inl.h changes because they likely lead to minor bloating
and the improvement was not clear on the test bot.

Powered by Google App Engine
This is Rietveld 408576698