Issue 8822006: Fix the app notify channel setup for the case where the user may have explicitly revoked permissi...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8822006: Fix the app notify channel setup for the case where the user may have explicitly revoked permissi... (Closed)

Created:
9 years ago by Munjal (Google)

Modified:
9 years ago

Reviewers:
elvin, asargent_no_longer_on_chrome

CC:
chromium-reviews, jstritar+watch_chromium.org, Aaron Boodman, mihaip+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Fix the app notify channel setup for the case where the user may have explicitly revoked permission and hence the OAuth2 access token generation may fail. In that case, prompt the user. add unit tests and modify existing tests. TBR=asargent Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113164

Patch Set 1 #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+51 lines, -16 lines)			Patch
M	chrome/browser/extensions/app_notify_channel_setup.h	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/app_notify_channel_setup.cc	View	3 chunks	+22 lines, -6 lines	0 comments	Download
M	chrome/browser/extensions/app_notify_channel_setup_unittest.cc	View	5 chunks	+24 lines, -10 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages