aura: Draw shadows around tooltip windows.

aura: Draw shadows around tooltip windows.

Also, add padding around the tooltip text and disable the
border when shadows are enabled.

I'm also updating the existing shadow code in aura_shell to
clip corner images as needed when they're too large to fit
within the requested size.

BUG=106507
TEST=added


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113294

[Daniel Erat, 2011-12-06 19:13:31]

Varun, mind reviewing the tooltip changes?

Ben, mind looking at and approving the rest?

Before-and-after from a Chrome OS device at
http://www/~derat/no_crawl/20111206/tooltips-old.png and
http://www/~derat/no_crawl/20111206/tooltips-new.png .

[varunjain, 2011-12-06 19:25:38]

http://codereview.chromium.org/8821028/diff/4001/ui/aura_shell/shell_tooltip_...
File ui/aura_shell/shell_tooltip_manager.cc (right):

http://codereview.chromium.org/8821028/diff/4001/ui/aura_shell/shell_tooltip_...
ui/aura_shell/shell_tooltip_manager.cc:70: aura::TooltipClient::GetMaxWidth(x,
y) - 2 * kTooltipHorizontalPadding;
I think you can simply add the padding to the widget. See for example:
http://codereview.chromium.org/8780001/diff/6001/ui/aura_shell/shell_tooltip_...

[Ben Goodger (Google), 2011-12-06 19:27:03]

LGTM from a high level perspective. i'll leave it to you to sort out
presentation/layout issues with varun.

http://codereview.chromium.org/8821028/diff/4001/ui/aura_shell/image_grid.h
File ui/aura_shell/image_grid.h (right):

http://codereview.chromium.org/8821028/diff/4001/ui/aura_shell/image_grid.h#n...
ui/aura_shell/image_grid.h:84: gfx::Rect GetTopLeftClipRect() const {
I believe you can use unix_hacker for this type of method.

http://codereview.chromium.org/8821028/diff/4001/ui/aura_shell/shell_tooltip_...
File ui/aura_shell/shell_tooltip_manager.cc (right):

http://codereview.chromium.org/8821028/diff/4001/ui/aura_shell/shell_tooltip_...
ui/aura_shell/shell_tooltip_manager.cc:120: if
(CommandLine::ForCurrentProcess()->HasSwitch(switches::kAuraNoShadows))
needs braces

[Daniel Erat, 2011-12-06 21:34:18]

Thanks.  Another look, Varun?

http://codereview.chromium.org/8821028/diff/4001/ui/aura_shell/image_grid.h
File ui/aura_shell/image_grid.h (right):

http://codereview.chromium.org/8821028/diff/4001/ui/aura_shell/image_grid.h#n...
ui/aura_shell/image_grid.h:84: gfx::Rect GetTopLeftClipRect() const {
On 2011/12/06 19:27:03, Ben Goodger (Google) wrote:
> I believe you can use unix_hacker for this type of method.

Done.

http://codereview.chromium.org/8821028/diff/4001/ui/aura_shell/shell_tooltip_...
File ui/aura_shell/shell_tooltip_manager.cc (right):

http://codereview.chromium.org/8821028/diff/4001/ui/aura_shell/shell_tooltip_...
ui/aura_shell/shell_tooltip_manager.cc:70: aura::TooltipClient::GetMaxWidth(x,
y) - 2 * kTooltipHorizontalPadding;
On 2011/12/06 19:25:38, varunjain wrote:
> I think you can simply add the padding to the widget. See for example:
>
http://codereview.chromium.org/8780001/diff/6001/ui/aura_shell/shell_tooltip_...

Done.

http://codereview.chromium.org/8821028/diff/4001/ui/aura_shell/shell_tooltip_...
ui/aura_shell/shell_tooltip_manager.cc:120: if
(CommandLine::ForCurrentProcess()->HasSwitch(switches::kAuraNoShadows))
On 2011/12/06 19:27:03, Ben Goodger (Google) wrote:
> needs braces

Done.

[varunjain, 2011-12-06 21:50:45]

LGTM
Thanks!


On 2011/12/06 21:34:18, Daniel Erat wrote:
> Thanks.  Another look, Varun?
> 
> http://codereview.chromium.org/8821028/diff/4001/ui/aura_shell/image_grid.h
> File ui/aura_shell/image_grid.h (right):
> 
>
http://codereview.chromium.org/8821028/diff/4001/ui/aura_shell/image_grid.h#n...
> ui/aura_shell/image_grid.h:84: gfx::Rect GetTopLeftClipRect() const {
> On 2011/12/06 19:27:03, Ben Goodger (Google) wrote:
> > I believe you can use unix_hacker for this type of method.
> 
> Done.
> 
>
http://codereview.chromium.org/8821028/diff/4001/ui/aura_shell/shell_tooltip_...
> File ui/aura_shell/shell_tooltip_manager.cc (right):
> 
>
http://codereview.chromium.org/8821028/diff/4001/ui/aura_shell/shell_tooltip_...
> ui/aura_shell/shell_tooltip_manager.cc:70: aura::TooltipClient::GetMaxWidth(x,
> y) - 2 * kTooltipHorizontalPadding;
> On 2011/12/06 19:25:38, varunjain wrote:
> > I think you can simply add the padding to the widget. See for example:
> >
>
http://codereview.chromium.org/8780001/diff/6001/ui/aura_shell/shell_tooltip_...
> 
> Done.
> 
>
http://codereview.chromium.org/8821028/diff/4001/ui/aura_shell/shell_tooltip_...
> ui/aura_shell/shell_tooltip_manager.cc:120: if
> (CommandLine::ForCurrentProcess()->HasSwitch(switches::kAuraNoShadows))
> On 2011/12/06 19:27:03, Ben Goodger (Google) wrote:
> > needs braces
> 
> Done.

[commit-bot: I haz the power, 2011-12-06 22:10:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/derat@chromium.org/8821028/8002

[commit-bot: I haz the power, 2011-12-06 23:45:53]

Change committed as 113294