Laning http://codereview.chromium.org/8759014/ on behalf of kmixter:

Landing http://codereview.chromium.org/8759014/ on behalf of kmixter:

Add ONC VPN support for OpenVPN and L2TP/IPsec VPNs

Also simplifies some of the parsing code, adds type validation, brings
the WiFi security parsing up to spec, and improves the unit tests for
wifi so that they all verify the property_map_ fields (the only ones
actually used to configure the network). Also fixed a general parser
problem where certificates wouldn't be parsed if network configs were.

BUG=chromium-os:23476
chromium-os:23477
TEST=manual import of ONC file with openvpn network, unit_tests

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113120
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113296

[kmixter1, 2011-12-06 18:06:53]

Not sure if this has landed, but it's got some bugs - they should show up in
unit tests.

http://codereview.chromium.org/8821023/diff/6001/chrome/browser/chromeos/cros...
File chrome/browser/chromeos/cros/onc_network_parser.cc (right):

http://codereview.chromium.org/8821023/diff/6001/chrome/browser/chromeos/cros...
chrome/browser/chromeos/cros/onc_network_parser.cc:780: scoped_ptr<Value>
value(Value::CreateStringValue(std::string()));
this is shadowing the value passed in - so hostname will always be empty string
too.

http://codereview.chromium.org/8821023/diff/6001/chrome/browser/chromeos/cros...
chrome/browser/chromeos/cros/onc_network_parser.cc:817: scoped_ptr<Value>
value(Value::CreateStringValue(std::string()));
same problem as above.

[zel, 2011-12-06 18:35:51]

http://codereview.chromium.org/8821023/diff/6001/chrome/browser/chromeos/cros...
File chrome/browser/chromeos/cros/onc_network_parser.cc (right):

http://codereview.chromium.org/8821023/diff/6001/chrome/browser/chromeos/cros...
chrome/browser/chromeos/cros/onc_network_parser.cc:780: scoped_ptr<Value>
value(Value::CreateStringValue(std::string()));
On 2011/12/06 18:06:54, kmixter1 wrote:
> this is shadowing the value passed in - so hostname will always be empty
string
> too.

Done.

http://codereview.chromium.org/8821023/diff/6001/chrome/browser/chromeos/cros...
chrome/browser/chromeos/cros/onc_network_parser.cc:817: scoped_ptr<Value>
value(Value::CreateStringValue(std::string()));
On 2011/12/06 18:06:54, kmixter1 wrote:
> same problem as above.

Done.

[kmixter1, 2011-12-06 19:25:03]

LGTM

http://codereview.chromium.org/8821023/diff/6001/chrome/browser/chromeos/cros...
File chrome/browser/chromeos/cros/onc_network_parser.cc (right):

http://codereview.chromium.org/8821023/diff/6001/chrome/browser/chromeos/cros...
chrome/browser/chromeos/cros/onc_network_parser.cc:47: };
This was a bug in my original CL.  There should be a { NULL } terminator here
(like the other arrays below).  Mattias found this yesterday.  Seems to not have
caused crashes yet, but it could.

[zel, 2011-12-06 19:28:03]

http://codereview.chromium.org/8821023/diff/6001/chrome/browser/chromeos/cros...
File chrome/browser/chromeos/cros/onc_network_parser.cc (right):

http://codereview.chromium.org/8821023/diff/6001/chrome/browser/chromeos/cros...
chrome/browser/chromeos/cros/onc_network_parser.cc:47: };
On 2011/12/06 19:25:03, kmixter1 wrote:
> This was a bug in my original CL.  There should be a { NULL } terminator here
> (like the other arrays below).  Mattias found this yesterday.  Seems to not
have
> caused crashes yet, but it could.

Done.