src/ia32/lithium-codegen-ia32.cc - Issue 8821019: Porting Math.pow changes to x64.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/lithium-codegen-ia32.cc

Issue 8821019: Porting Math.pow changes to x64. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: . Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ia32/lithium-codegen-ia32.cc

diff --git a/src/ia32/lithium-codegen-ia32.cc b/src/ia32/lithium-codegen-ia32.cc

index 965dc4431d1f372ddc0fbd18c0c386303cc00db2..dfd0bb462a14df9210c241f20d3f3859912ce766 100644

--- a/src/ia32/lithium-codegen-ia32.cc

+++ b/src/ia32/lithium-codegen-ia32.cc

@@ -2991,7 +2991,7 @@ void LCodeGen::DoMathPowHalf(LMathPowHalf* instr) {

void LCodeGen::DoPower(LPower* instr) {

Representation exponent_type = instr->hydrogen()->right()->representation();

// Having marked this as a call, we can use any registers.

- // Just make sure that the input registers are the expected ones.

+ // Just make sure that the input/output registers are the expected ones.

ASSERT(!instr->InputAt(1)->IsDoubleRegister() ||

ulan 2011/12/06 17:38:04 Don't forget to change the assertions to reflect r

ToDoubleRegister(instr->InputAt(1)).is(xmm2));

ASSERT(!instr->InputAt(1)->IsRegister() ||

« no previous file with comments | « src/ia32/code-stubs-ia32.cc ('k') | src/ia32/lithium-ia32.cc » ('j') | no next file with comments »