Issue 8821002: Honor server requested origin bound client cert types.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8821002: Honor server requested origin bound client cert types. (Closed)

Created:
9 years ago by mattm

Modified:
9 years ago

Reviewers:
wtc

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Honor server requested origin bound client cert types. BUG=88782 TEST=changed certificate_types struct in local copy of nss selfserv, reloaded, checked "echo .dump | sqlite3 'Origin Bound Certs'" to see if new cert was generated. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113159

Patch Set 1 #

Total comments: 1

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -12 lines)			Patch
	M	net/socket/ssl_client_socket_nss.h	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	net/socket/ssl_client_socket_nss.cc	View		3 chunks	+9 lines, -11 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

wtc

LGTM. http://codereview.chromium.org/8821002/diff/1/net/socket/ssl_client_socket_nss.cc File net/socket/ssl_client_socket_nss.cc (right): http://codereview.chromium.org/8821002/diff/1/net/socket/ssl_client_socket_nss.cc#newcode2153 net/socket/ssl_client_socket_nss.cc:2153: cert_types->data + cert_types->len); Since we still need to ...

9 years ago (2011-12-06 02:47:58 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mattm@chromium.org/8821002/1

9 years ago (2011-12-06 06:19:53 UTC) #3

Change committed as 113159

Expand Messages | Collapse Messages