Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1072)

Unified Diff: build/download_nacl_toolchains.py

Issue 8820022: Don't download the NaCl toolchain if GYP_DEFINES contains disable_nacl=1 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/download_nacl_toolchains.py
diff --git a/build/download_nacl_toolchains.py b/build/download_nacl_toolchains.py
index 580f410dd799e3e81bddb38f0305a1dee284a478..46c7879e3ac27705de10ae111c1bbf841e300f08 100755
--- a/build/download_nacl_toolchains.py
+++ b/build/download_nacl_toolchains.py
@@ -10,6 +10,9 @@ import sys
def Main(args):
+ # Exit early if disable_nacl=1.
+ if 'disable_nacl=1' in os.environ.get('GYP_DEFINES', ''):
bradn 2011/12/06 18:36:16 How about 'disable_nacl=1' in os.environ.get('GYP_
jochen (gone - plz use gerrit) 2011/12/06 18:40:51 I don't feel strongly about this, I just duplicate
+ return 0
# Handle chromeos=1 specially (until its building its own toolchain).
if 'chromeos=1' in os.environ.get('GYP_DEFINES', ''):
args = [
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698