Don't download the NaCl toolchain if GYP_DEFINES contains disable_nacl=1

Don't download the NaCl toolchain if GYP_DEFINES contains disable_nacl=1

BUG=none
TEST=manual


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113279

[jochen (gone - plz use gerrit), 2011-12-06 18:27:38]

plz review

[bradn, 2011-12-06 18:36:16]

lgtm

http://codereview.chromium.org/8820022/diff/1/build/download_nacl_toolchains.py
File build/download_nacl_toolchains.py (right):

http://codereview.chromium.org/8820022/diff/1/build/download_nacl_toolchains....
build/download_nacl_toolchains.py:14: if 'disable_nacl=1' in
os.environ.get('GYP_DEFINES', ''):
How about 'disable_nacl=1' in os.environ.get('GYP_DEFINES', '').split(' '):

[jochen (gone - plz use gerrit), 2011-12-06 18:40:51]

http://codereview.chromium.org/8820022/diff/1/build/download_nacl_toolchains.py
File build/download_nacl_toolchains.py (right):

http://codereview.chromium.org/8820022/diff/1/build/download_nacl_toolchains....
build/download_nacl_toolchains.py:14: if 'disable_nacl=1' in
os.environ.get('GYP_DEFINES', ''):
On 2011/12/06 18:36:16, bradn wrote:
> How about 'disable_nacl=1' in os.environ.get('GYP_DEFINES', '').split(' '):

I don't feel strongly about this, I just duplicated the chromeos=1 check in the
next line

[bradn, 2011-12-06 18:42:26]

ok, fair enough. as you have it then.

On Tue, Dec 6, 2011 at 10:40 AM, <jochen@chromium.org> wrote:

>
> http://codereview.chromium.**org/8820022/diff/1/build/**
>
download_nacl_toolchains.py<http://codereview.chromium.org/8820022/diff/1/build/download_nacl_toolchains.py>
> File build/download_nacl_**toolchains.py (right):
>
> http://codereview.chromium.**org/8820022/diff/1/build/**
>
download_nacl_toolchains.py#**newcode14<http://codereview.chromium.org/8820022/diff/1/build/download_nacl_toolchains.py#newcode14>
> build/download_nacl_**toolchains.py:14: if 'disable_nacl=1' in
> os.environ.get('GYP_DEFINES', ''):
> On 2011/12/06 18:36:16, bradn wrote:
>
>> How about 'disable_nacl=1' in os.environ.get('GYP_DEFINES',
>>
> '').split(' '):
>
> I don't feel strongly about this, I just duplicated the chromeos=1 check
> in the next line
>
>
http://codereview.chromium.**org/8820022/<http://codereview.chromium.org/8820...
>

[commit-bot: I haz the power, 2011-12-06 18:46:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jochen@chromium.org/8820022/1

[commit-bot: I haz the power, 2011-12-06 23:28:56]

Change committed as 113279