Issue 8820019: [Sync] Set HasCustomGroupsToChange() to true for VerifyUpdatesCommand

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8820019: [Sync] Set HasCustomGroupsToChange() to true for VerifyUpdatesCommand (Closed)

Created:
9 years ago by akalin

Modified:
9 years ago

Reviewers:
tim (not reviewing)

CC:
chromium-reviews, Raghu Simha, ncarter (slow), tim (not reviewing)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Sync] Set HasCustomGroupsToChange() to true for VerifyUpdatesCommand Follow-up to 113090 to see which ModelChangingSyncerCommand triggers a perf regression. BUG=97832 TEST= TBR=tim Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113319 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114042

Patch Set 1 #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	chrome/browser/sync/engine/verify_updates_command.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

akalin

On 2011/12/06 17:28:42, akalin wrote: > +tim for review (although I may TBR this) This ...

9 years ago (2011-12-07 03:13:11 UTC) #2

akalin

9 years ago (2011-12-07 04:10:33 UTC) #3

On 2011/12/07 03:13:11, akalin wrote:
> On 2011/12/06 17:28:42, akalin wrote:
> > +tim for review (although I may TBR this)
> 
> This causes a perf regression in delete_typed_urls!

I believe the problem may lie in the fact that GetGroupsToChange involves
iterating over the list of updates (which is also done in
ModelChangingExecuteImpl).  That itself is an array traversal, but
GetModelType() is O(# of types).

It's hard to believe that even that could cause a noticeable difference.  But
it's possible, I guess. :/

Expand Messages | Collapse Messages