src/x64/builtins-x64.cc - Issue 8820014: Support Smi->Double->HeapObject transitions in constructed Arrays.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/builtins-x64.cc

Issue 8820014: Support Smi->Double->HeapObject transitions in constructed Arrays. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Review feedback Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/x64/builtins-x64.cc

diff --git a/src/x64/builtins-x64.cc b/src/x64/builtins-x64.cc

index e423ae3a4f6aad6acbf048f974c959fd9718e04c..1719496c85ffc55c31b805c699c15cf7742bcbfd 100644

--- a/src/x64/builtins-x64.cc

+++ b/src/x64/builtins-x64.cc

@@ -1305,6 +1305,9 @@ static void ArrayNativeCode(MacroAssembler* masm,

__ jmp(&entry);

__ bind(&loop);

__ movq(kScratchRegister, Operand(r9, rcx, times_pointer_size, 0));

+ if (FLAG_smi_only_arrays) {

+ __ JumpIfNotSmi(kScratchRegister, call_generic_code);

+ }

__ movq(Operand(rdx, 0), kScratchRegister);

__ addq(rdx, Immediate(kPointerSize));

__ bind(&entry);

« no previous file with comments | « src/runtime.cc ('k') | test/mjsunit/array-construct-transition.js » ('j') | no next file with comments »