Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(677)

Side by Side Diff: chrome/browser/session_history_uitest.cc

Issue 8820013: Flaky on Windows: SessionHistoryTest.FrameBackForward. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/string_util.h" 5 #include "base/string_util.h"
6 #include "chrome/common/url_constants.h" 6 #include "chrome/common/url_constants.h"
7 #include "chrome/test/automation/automation_proxy.h" 7 #include "chrome/test/automation/automation_proxy.h"
8 #include "chrome/test/automation/browser_proxy.h" 8 #include "chrome/test/automation/browser_proxy.h"
9 #include "chrome/test/automation/tab_proxy.h" 9 #include "chrome/test/automation/tab_proxy.h"
10 #include "chrome/test/ui/ui_test.h" 10 #include "chrome/test/ui/ui_test.h"
(...skipping 129 matching lines...) Expand 10 before | Expand all | Expand 10 after
140 EXPECT_EQ(L"about:blank", GetTabTitle()); 140 EXPECT_EQ(L"about:blank", GetTabTitle());
141 141
142 ASSERT_TRUE(tab_->GoForward()); 142 ASSERT_TRUE(tab_->GoForward());
143 EXPECT_EQ(L"bot1", GetTabTitle()); 143 EXPECT_EQ(L"bot1", GetTabTitle());
144 144
145 ASSERT_TRUE(tab_->GoForward()); 145 ASSERT_TRUE(tab_->GoForward());
146 EXPECT_EQ(L"bot3", GetTabTitle()); 146 EXPECT_EQ(L"bot3", GetTabTitle());
147 } 147 }
148 148
149 // Test that back/forward works when navigating in subframes. 149 // Test that back/forward works when navigating in subframes.
150 #if defined(OS_WIN)
151 // http://crbug.com/48833
152 #define FrameBackForward FLAKY_FrameBackForward
153 #endif
150 TEST_F(SessionHistoryTest, FrameBackForward) { 154 TEST_F(SessionHistoryTest, FrameBackForward) {
151 ASSERT_TRUE(test_server_.Start()); 155 ASSERT_TRUE(test_server_.Start());
152 156
153 // about:blank should be loaded first. 157 // about:blank should be loaded first.
154 GURL home(homepage()); 158 GURL home(homepage());
155 ASSERT_FALSE(tab_->GoBack()); 159 ASSERT_FALSE(tab_->GoBack());
156 EXPECT_EQ(L"about:blank", GetTabTitle()); 160 EXPECT_EQ(L"about:blank", GetTabTitle());
157 EXPECT_EQ(home, GetTabURL()); 161 EXPECT_EQ(home, GetTabURL());
158 162
159 GURL frames(test_server_.GetURL("files/session_history/frames.html")); 163 GURL frames(test_server_.GetURL("files/session_history/frames.html"));
(...skipping 393 matching lines...) Expand 10 before | Expand all | Expand 10 after
553 ASSERT_TRUE(tab_->GoBack()); 557 ASSERT_TRUE(tab_->GoBack());
554 558
555 // Ensure history.length is properly truncated. 559 // Ensure history.length is properly truncated.
556 ASSERT_TRUE(tab_->NavigateToURL(test_server_.GetURL("files/title2.html"))); 560 ASSERT_TRUE(tab_->NavigateToURL(test_server_.GetURL("files/title2.html")));
557 ASSERT_TRUE(tab_->ExecuteAndExtractInt( 561 ASSERT_TRUE(tab_->ExecuteAndExtractInt(
558 L"", L"domAutomationController.send(history.length)", &length)); 562 L"", L"domAutomationController.send(history.length)", &length));
559 EXPECT_EQ(2, length); 563 EXPECT_EQ(2, length);
560 } 564 }
561 565
562 } // namespace 566 } // namespace
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698