Appcache, local storage, indexed db, databases: skip exit-time deletion when restarting.

Appcache, local storage, indexed db, databases: skip exit-time deletion when restarting.


BUG=104291
TEST={ChromeAppCacheServiceTest, DOMStorageTest, IndexedDBBrowserTest, DatabaseTrackerTest}.SaveSessionState


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113590

[marja, 2011-12-07 12:11:13]

Hi {michaeln,mirandac}!

This CL makes appcache, webkit context, indexed db and databases skip the "clear
on exit" behaviour when we're about to restart chrome do a session restore.

I also unified the "clear on exit" behaviour of DOMStorageContext and
IndexedDBContext. When I added that feature, I0 had ended up doing it
inconsistently for no clear reason.

Could you review the following parts:
michaeln: all
mirandac: chrome/browser/profiles/*

[Miranda Callahan, 2011-12-07 15:05:09]

On 2011/12/07 12:11:13, marja wrote:
> Hi {michaeln,mirandac}!
> 
> This CL makes appcache, webkit context, indexed db and databases skip the
"clear
> on exit" behaviour when we're about to restart chrome do a session restore.
> 
> I also unified the "clear on exit" behaviour of DOMStorageContext and
> IndexedDBContext. When I added that feature, I0 had ended up doing it
> inconsistently for no clear reason.
> 
> Could you review the following parts:
> michaeln: all
> mirandac: chrome/browser/profiles/*

If setting the appcache data on the IOThread is threadsafe, profiles/* LGTM.

[michaeln, 2011-12-07 20:49:15]

http://codereview.chromium.org/8820009/diff/6001/webkit/appcache/appcache_ser...
File webkit/appcache/appcache_service.h (right):

http://codereview.chromium.org/8820009/diff/6001/webkit/appcache/appcache_ser...
webkit/appcache/appcache_service.h:150: void set_save_session_state(bool
save_session_state) {
indent is off

http://codereview.chromium.org/8820009/diff/6001/webkit/appcache/appcache_sto...
File webkit/appcache/appcache_storage_impl.cc (right):

http://codereview.chromium.org/8820009/diff/6001/webkit/appcache/appcache_sto...
webkit/appcache/appcache_storage_impl.cc:1189: if (database_ &&
!service()->save_session_state()) {
Since CleanUpOnDatabaseThread is also responsible for deleting the db_ instance,
this has to be massages a little to allow that to happen.

[marja, 2011-12-08 08:30:12]

Thanks for comments!

http://codereview.chromium.org/8820009/diff/6001/webkit/appcache/appcache_ser...
File webkit/appcache/appcache_service.h (right):

http://codereview.chromium.org/8820009/diff/6001/webkit/appcache/appcache_ser...
webkit/appcache/appcache_service.h:150: void set_save_session_state(bool
save_session_state) {
On 2011/12/07 20:49:15, michaeln wrote:
> indent is off

Done.

http://codereview.chromium.org/8820009/diff/6001/webkit/appcache/appcache_sto...
File webkit/appcache/appcache_storage_impl.cc (right):

http://codereview.chromium.org/8820009/diff/6001/webkit/appcache/appcache_sto...
webkit/appcache/appcache_storage_impl.cc:1189: if (database_ &&
!service()->save_session_state()) {
On 2011/12/07 20:49:15, michaeln wrote:
> Since CleanUpOnDatabaseThread is also responsible for deleting the db_
instance,
> this has to be massages a little to allow that to happen.

Done.

[michaeln, 2011-12-08 09:26:01]

lgtm

[commit-bot: I haz the power, 2011-12-08 09:29:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/marja@chromium.org/8820009/11001

[commit-bot: I haz the power, 2011-12-08 10:44:06]

Change committed as 113590