Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(645)

Unified Diff: content/renderer/render_widget.cc

Issue 8820001: Send the pending input event ack before the UpdateRect message (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/renderer_host/render_widget_host.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_widget.cc
diff --git a/content/renderer/render_widget.cc b/content/renderer/render_widget.cc
index cd50991e3b785568574b54c74d85b9582145bc7e..1edd49f3ec3d463a0b46ad2c6d4292b9b9e7d476 100644
--- a/content/renderer/render_widget.cc
+++ b/content/renderer/render_widget.cc
@@ -447,6 +447,9 @@ void RenderWidget::OnHandleInputEvent(const IPC::Message& message) {
bool prevent_default = false;
if (WebInputEvent::isMouseEventType(input_event->type)) {
+ TRACE_EVENT2("renderer", "HandleMouseMove",
darin (slow to review) 2011/12/06 23:19:48 nit: maybe this code would be cleaner with a local
+ "x", static_cast<const WebMouseEvent*>(input_event)->x,
+ "y", static_cast<const WebMouseEvent*>(input_event)->y);
prevent_default = WillHandleMouseEvent(
*(static_cast<const WebMouseEvent*>(input_event)));
}
@@ -839,6 +842,9 @@ void RenderWidget::DoDeferredUpdate() {
params.flags = next_paint_flags_;
params.scroll_offset = GetScrollOffset();
+ if (pending_input_event_ack_.get())
darin (slow to review) 2011/12/06 23:19:48 This probably deserves a comment.
+ Send(pending_input_event_ack_.release());
+
update_reply_pending_ = true;
Send(new ViewHostMsg_UpdateRect(routing_id_, params));
next_paint_flags_ = 0;
« no previous file with comments | « content/browser/renderer_host/render_widget_host.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698