Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Side by Side Diff: chrome/browser/sync/engine/process_commit_response_command.cc

Issue 8819027: [Sync] Set HasCustomGroupsToChange() to true for ProcessCommitResponseCommand (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/sync/engine/process_commit_response_command.h" 5 #include "chrome/browser/sync/engine/process_commit_response_command.h"
6 6
7 #include <cstddef> 7 #include <cstddef>
8 #include <set> 8 #include <set>
9 #include <string> 9 #include <string>
10 #include <vector> 10 #include <vector>
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
54 status->increment_num_consecutive_errors(); 54 status->increment_num_consecutive_errors();
55 } 55 }
56 void ResetErrorCounters(StatusController* status) { 56 void ResetErrorCounters(StatusController* status) {
57 status->set_num_consecutive_errors(0); 57 status->set_num_consecutive_errors(0);
58 } 58 }
59 59
60 ProcessCommitResponseCommand::ProcessCommitResponseCommand() {} 60 ProcessCommitResponseCommand::ProcessCommitResponseCommand() {}
61 ProcessCommitResponseCommand::~ProcessCommitResponseCommand() {} 61 ProcessCommitResponseCommand::~ProcessCommitResponseCommand() {}
62 62
63 bool ProcessCommitResponseCommand::HasCustomGroupsToChange() const { 63 bool ProcessCommitResponseCommand::HasCustomGroupsToChange() const {
64 // TODO(akalin): Set to true. 64 return true;
65 return false;
66 } 65 }
67 66
68 std::set<ModelSafeGroup> ProcessCommitResponseCommand::GetGroupsToChange( 67 std::set<ModelSafeGroup> ProcessCommitResponseCommand::GetGroupsToChange(
69 const sessions::SyncSession& session) const { 68 const sessions::SyncSession& session) const {
70 std::set<ModelSafeGroup> groups_with_commits; 69 std::set<ModelSafeGroup> groups_with_commits;
71 syncable::ScopedDirLookup dir(session.context()->directory_manager(), 70 syncable::ScopedDirLookup dir(session.context()->directory_manager(),
72 session.context()->account_name()); 71 session.context()->account_name());
73 if (!dir.good()) { 72 if (!dir.good()) {
74 LOG(ERROR) << "Scoped dir lookup failed!"; 73 LOG(ERROR) << "Scoped dir lookup failed!";
75 return groups_with_commits; 74 return groups_with_commits;
(...skipping 436 matching lines...) Expand 10 before | Expand all | Expand 10 after
512 // been recursively deleted. 511 // been recursively deleted.
513 // TODO(nick): Here, commit_message.deleted() would be more correct than 512 // TODO(nick): Here, commit_message.deleted() would be more correct than
514 // local_entry->Get(IS_DEL). For example, an item could be renamed, and then 513 // local_entry->Get(IS_DEL). For example, an item could be renamed, and then
515 // deleted during the commit of the rename. Unit test & fix. 514 // deleted during the commit of the rename. Unit test & fix.
516 if (local_entry->Get(IS_DIR) && local_entry->Get(IS_DEL)) { 515 if (local_entry->Get(IS_DIR) && local_entry->Get(IS_DEL)) {
517 deleted_folders->insert(local_entry->Get(ID)); 516 deleted_folders->insert(local_entry->Get(ID));
518 } 517 }
519 } 518 }
520 519
521 } // namespace browser_sync 520 } // namespace browser_sync
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698