[filebrowser] Fix the browser_tests using invalid mount point.

chrome/browser/ui/views/select_file_dialog_extension_browsertest.cc

Index: chrome/browser/ui/views/select_file_dialog_extension_browsertest.cc
===================================================================
--- chrome/browser/ui/views/select_file_dialog_extension_browsertest.cc	(revision 113190)
+++ chrome/browser/ui/views/select_file_dialog_extension_browsertest.cc	(working copy)
@@ -218,7 +218,8 @@
   // Add tmp mount point even though this test won't use it directly.
   // We need this to make sure that at least one top-level directory exists
   // in the file browser.
-  FilePath tmp_dir("/tmp");
+  FilePath tmp_dir("/tmp/Downloads");
+  file_util::CreateDirectory(tmp_dir);

[zel, 2011/12/06 16:14:19]

You should use ScopedTempDir class for this purpose.


http://codesearch.google.com/#OAMlx_jo-ck/src/base/scoped_temp_dir.h

[dgozman, 2011/12/06 17:11:55]

Done.

   AddMountPoint(tmp_dir);
 
   gfx::NativeWindow owning_window = browser()->window()->GetNativeHandle();
@@ -244,8 +245,10 @@
 IN_PROC_BROWSER_TEST_F(SelectFileDialogExtensionBrowserTest,
                        MAYBE_SelectFileAndOpen) {
   // Allow the tmp directory to be mounted.  We explicitly use /tmp because
-  // it it whitelisted for file system access on Chrome OS.
-  FilePath tmp_dir("/tmp");
+  // it is whitelisted for file system access on Chrome OS.
+  // File manager looks for Downloads mount point, so use this name.
+  FilePath tmp_dir("/tmp/Downloads");
+  file_util::CreateDirectory(tmp_dir);
   AddMountPoint(tmp_dir);
 
   // Create a directory with a single file in it.  ScopedTempDir will delete
@@ -289,8 +292,10 @@
 IN_PROC_BROWSER_TEST_F(SelectFileDialogExtensionBrowserTest,
                        MAYBE_SelectFileAndSave) {
   // Allow the tmp directory to be mounted.  We explicitly use /tmp because
-  // it it whitelisted for file system access on Chrome OS.
-  FilePath tmp_dir("/tmp");
+  // it is whitelisted for file system access on Chrome OS.
+  // File manager looks for Downloads mount point, so use this name.
+  FilePath tmp_dir("/tmp/Downloads");
+  file_util::CreateDirectory(tmp_dir);
   AddMountPoint(tmp_dir);
 
   // Create a directory with a single file in it.  ScopedTempDir will delete
@@ -331,7 +336,8 @@
   // Add tmp mount point even though this test won't use it directly.
   // We need this to make sure that at least one top-level directory exists
   // in the file browser.
-  FilePath tmp_dir("/tmp");
+  FilePath tmp_dir("/tmp/Downloads");
+  file_util::CreateDirectory(tmp_dir);
   AddMountPoint(tmp_dir);
 
   gfx::NativeWindow owning_window = browser()->window()->GetNativeHandle();
@@ -365,7 +371,8 @@
   // Add tmp mount point even though this test won't use it directly.
   // We need this to make sure that at least one top-level directory exists
   // in the file browser.
-  FilePath tmp_dir("/tmp");
+  FilePath tmp_dir("/tmp/Downloads");
+  file_util::CreateDirectory(tmp_dir);
   AddMountPoint(tmp_dir);
 
   gfx::NativeWindow owning_window = browser()->window()->GetNativeHandle();