Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8819019: Fixed 'singleton' behavior of filebrowser (Closed)

Created:
9 years ago by Dmitry Zvorygin
Modified:
8 years, 10 months ago
Reviewers:
rginda, dgozman, zel, SeRya, sky
CC:
chromium-reviews
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Merged with latest changes. #

Patch Set 3 : Fixed aurora compilation error. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/ui/browser.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
dgozman
LGTM with comment addressed http://codereview.chromium.org/8819019/diff/1/chrome/browser/ui/browser.cc File chrome/browser/ui/browser.cc (right): http://codereview.chromium.org/8819019/diff/1/chrome/browser/ui/browser.cc#newcode2241 chrome/browser/ui/browser.cc:2241: NEW_FOREGROUND_TAB, content::PAGE_TRANSITION_LINK); Are you sure ...
9 years ago (2011-12-06 13:22:27 UTC) #1
commit-bot: I haz the power
No LGTM from any valid reviewer yet. Even if a LGTM may have been provided, ...
8 years, 11 months ago (2012-01-20 10:30:45 UTC) #2
Dmitry Zvorygin
http://codereview.chromium.org/8819019/diff/1/chrome/browser/ui/browser.cc File chrome/browser/ui/browser.cc (right): http://codereview.chromium.org/8819019/diff/1/chrome/browser/ui/browser.cc#newcode2241 chrome/browser/ui/browser.cc:2241: NEW_FOREGROUND_TAB, content::PAGE_TRANSITION_LINK); On 2011/12/06 13:22:27, dgozman wrote: > Are ...
8 years, 11 months ago (2012-01-20 10:32:03 UTC) #3
sky
LGTM
8 years, 10 months ago (2012-01-30 22:55:36 UTC) #4
zel
lgtm
8 years, 10 months ago (2012-01-30 23:40:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zvorygin@chromium.org/8819019/1
8 years, 10 months ago (2012-01-31 11:35:15 UTC) #6
commit-bot: I haz the power
Can't apply patch for file chrome/browser/ui/browser.cc. While running patch -p1 --forward --force; patching file chrome/browser/ui/browser.cc ...
8 years, 10 months ago (2012-01-31 11:35:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zvorygin@chromium.org/8819019/9001
8 years, 10 months ago (2012-01-31 13:26:45 UTC) #8
commit-bot: I haz the power
Change committed as 119897
8 years, 10 months ago (2012-01-31 16:38:27 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zvorygin@chromium.org/8819019/12001
8 years, 10 months ago (2012-02-01 10:56:05 UTC) #10
commit-bot: I haz the power
8 years, 10 months ago (2012-02-01 13:19:57 UTC) #11 
Change committed as 120058

Powered by Google App Engine
This is Rietveld 408576698