Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Issue 8819011: Revert 113120 - this CL broke then chromeos clang bot: (Closed)

Created:
9 years ago by sail
Modified:
9 years ago
Reviewers:
kmixter1
CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Revert 113120 - this CL broke then chromeos clang bot: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20Clang%20%28ChromeOS%20dbg%29/builds/4017/steps/compile/logs/stdio Add ONC VPN support for OpenVPN and L2TP/IPsec VPNs Also simplifies some of the parsing code, adds type validation, brings the WiFi security parsing up to spec, and improves the unit tests for wifi so that they all verify the property_map_ fields (the only ones actually used to configure the network). Also fixed a general parser problem where certificates wouldn't be parsed if network configs were. BUG=chromium-os:23476 chromium-os:23477 TEST=manual import of ONC file with openvpn network, unit_tests Review URL: http://codereview.chromium.org/8759014 TBR=kmixter@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113136

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+309 lines, -1119 lines) Patch
M chrome/browser/chromeos/cros/native_network_parser.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/cros/native_network_parser.cc View 6 chunks +8 lines, -66 lines 0 comments Download
M chrome/browser/chromeos/cros/network_library.h View 6 chunks +6 lines, -52 lines 0 comments Download
M chrome/browser/chromeos/cros/network_library.cc View 6 chunks +2 lines, -23 lines 0 comments Download
M chrome/browser/chromeos/cros/onc_network_parser.h View 6 chunks +19 lines, -86 lines 0 comments Download
M chrome/browser/chromeos/cros/onc_network_parser.cc View 15 chunks +235 lines, -598 lines 0 comments Download
M chrome/browser/chromeos/cros/onc_network_parser_unittest.cc View 11 chunks +39 lines, -293 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
sail
9 years ago (2011-12-06 07:03:56 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698