Issue 8819010: Webcam ppapi flash fix.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8819010: Webcam ppapi flash fix. (Closed)

Created:
9 years ago by ilja

Modified:
9 years ago

Reviewers:
wjia(left Chromium), piman

CC:
chromium-reviews, hclam+watch_chromium.org, ddorwin+watch_chromium.org, fischman+watch_chromium.org, jam, acolwell+watch_chromium.org, annacc+watch_chromium.org, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, vrk (LEFT CHROMIUM), scherkus (not reviewing), ihf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Webcam ppapi flash fix. Return buffers that are in flight during shutdown and make sure to issue defered stop. BUG=106369 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113467

Patch Set 1 #

Patch Set 2 : '' #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -16 lines)			Patch
	M	content/browser/renderer_host/media/video_capture_controller.cc	View	1	1 chunk	+8 lines, -0 lines	0 comments	Download
	M	webkit/plugins/ppapi/ppb_video_capture_impl.cc	View	1	1 chunk	+17 lines, -16 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

wjia(left Chromium)

lgtm. Could you use patch http://codereview.chromium.org/8806031/ for the change in video_capture_controller.cc? Thanks!

9 years ago (2011-12-06 18:13:37 UTC) #2

ilja

I have updated and tested this change as you suggested. If you want I can ...

9 years ago (2011-12-07 05:09:05 UTC) #3

wjia(left Chromium)

LGTM. Thanks, Ilja! Adding piman for ppapi owner stamp.

9 years ago (2011-12-07 05:32:52 UTC) #4

lgtm

Expand Messages | Collapse Messages