Issue 8819005: Get rid of the last view_messages.h include in chrome, other than tab_contents_views_mac.mm and r...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8819005: Get rid of the last view_messages.h include in chrome, other than tab_contents_views_mac.mm and r... (Closed)

Created:
9 years ago by jam

Modified:
9 years ago

Reviewers:
Dirk Pranke

CC:
chromium-reviews, Avi (use Gerrit), creis+watch_chromium.org, ajwong+watch_chromium.org, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, Paweł Hajdan Jr., darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Get rid of the last view_messages.h include in chrome, other than tab_contents_views_mac.mm and render_view_host_delegate_helper.cc, both of which Avi is working on. I added a test method to fake a UpdateRect IPC message for the thumbnail test. BUG=98716 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113285

Patch Set 1 #

Patch Set 2 : '' #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -10 lines)			Patch
M	chrome/browser/tab_contents/thumbnail_generator_unittest.cc	View	1	2 chunks	+2 lines, -10 lines	0 comments	Download
M	content/browser/renderer_host/test_render_view_host.h	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	content/browser/renderer_host/test_render_view_host.cc	View		1 chunk	+14 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jam@chromium.org/8819005/1004

9 years ago (2011-12-06 21:46:50 UTC) #3

Change committed as 113285

Expand Messages | Collapse Messages