Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 8818020: Fixed the editing of previously edited files (Closed)

Created:
9 years ago by Vladislav Kaznacheev
Modified:
9 years ago
Reviewers:
dgozman, SeRya
CC:
chromium-reviews, rginda+watch_chromium.org, arv (Not doing code reviews), achuith+watch_chromium.org
Visibility:
Public.

Description

Fixed the editing of previously edited files BUG=chromium-os:23768 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113389

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comments, added a TODO #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -13 lines) Patch
M chrome/browser/resources/file_manager/js/image_editor/gallery.js View 1 2 chunks +19 lines, -13 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Vladislav Kaznacheev
Please review. This patch solves the problem of editing a file that is already a ...
9 years ago (2011-12-06 18:30:16 UTC) #1
dgozman
LGTM http://codereview.chromium.org/8818020/diff/1/chrome/browser/resources/file_manager/js/image_editor/gallery.js File chrome/browser/resources/file_manager/js/image_editor/gallery.js (right): http://codereview.chromium.org/8818020/diff/1/chrome/browser/resources/file_manager/js/image_editor/gallery.js#newcode877 chrome/browser/resources/file_manager/js/image_editor/gallery.js:877: new RegExp('^' + Ribbon.Item.COPY_SIGNATURE + '(.+) \\((\\d+)\\)$'); You ...
9 years ago (2011-12-07 06:02:09 UTC) #2
Vladislav Kaznacheev
http://codereview.chromium.org/8818020/diff/1/chrome/browser/resources/file_manager/js/image_editor/gallery.js File chrome/browser/resources/file_manager/js/image_editor/gallery.js (right): http://codereview.chromium.org/8818020/diff/1/chrome/browser/resources/file_manager/js/image_editor/gallery.js#newcode877 chrome/browser/resources/file_manager/js/image_editor/gallery.js:877: new RegExp('^' + Ribbon.Item.COPY_SIGNATURE + '(.+) \\((\\d+)\\)$'); On 2011/12/07 ...
9 years ago (2011-12-07 13:11:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kaznacheev@chromium.org/8818020/4002
9 years ago (2011-12-07 13:11:39 UTC) #4
commit-bot: I haz the power
9 years ago (2011-12-07 14:24:27 UTC) #5
Change committed as 113389

Powered by Google App Engine
This is Rietveld 408576698