Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(954)

Side by Side Diff: chrome/browser/sync/engine/apply_updates_command.cc

Issue 8818019: [Sync] Set HasCustomGroupsToChange() to true for ApplyUpdatesCommand (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/sync/engine/apply_updates_command.h" 5 #include "chrome/browser/sync/engine/apply_updates_command.h"
6 6
7 #include "base/location.h" 7 #include "base/location.h"
8 #include "chrome/browser/sync/engine/update_applicator.h" 8 #include "chrome/browser/sync/engine/update_applicator.h"
9 #include "chrome/browser/sync/sessions/sync_session.h" 9 #include "chrome/browser/sync/sessions/sync_session.h"
10 #include "chrome/browser/sync/syncable/directory_manager.h" 10 #include "chrome/browser/sync/syncable/directory_manager.h"
11 #include "chrome/browser/sync/syncable/syncable.h" 11 #include "chrome/browser/sync/syncable/syncable.h"
12 12
13 namespace browser_sync { 13 namespace browser_sync {
14 14
15 using sessions::SyncSession; 15 using sessions::SyncSession;
16 16
17 ApplyUpdatesCommand::ApplyUpdatesCommand() {} 17 ApplyUpdatesCommand::ApplyUpdatesCommand() {}
18 ApplyUpdatesCommand::~ApplyUpdatesCommand() {} 18 ApplyUpdatesCommand::~ApplyUpdatesCommand() {}
19 19
20 bool ApplyUpdatesCommand::HasCustomGroupsToChange() const { 20 bool ApplyUpdatesCommand::HasCustomGroupsToChange() const {
21 // TODO(akalin): Set to true. 21 return true;
22 return false;
23 } 22 }
24 23
25 std::set<ModelSafeGroup> ApplyUpdatesCommand::GetGroupsToChange( 24 std::set<ModelSafeGroup> ApplyUpdatesCommand::GetGroupsToChange(
26 const sessions::SyncSession& session) const { 25 const sessions::SyncSession& session) const {
27 std::set<ModelSafeGroup> groups_with_unapplied_updates; 26 std::set<ModelSafeGroup> groups_with_unapplied_updates;
28 27
29 syncable::ModelTypeBitSet server_types_with_unapplied_updates; 28 syncable::ModelTypeBitSet server_types_with_unapplied_updates;
30 { 29 {
31 syncable::ScopedDirLookup dir(session.context()->directory_manager(), 30 syncable::ScopedDirLookup dir(session.context()->directory_manager(),
32 session.context()->account_name()); 31 session.context()->account_name());
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after
99 syncable::ModelType model_type = syncable::ModelTypeFromInt(i); 98 syncable::ModelType model_type = syncable::ModelTypeFromInt(i);
100 if (status.updates_request_types()[i]) { 99 if (status.updates_request_types()[i]) {
101 // This gets persisted to the directory's backing store. 100 // This gets persisted to the directory's backing store.
102 dir->set_initial_sync_ended_for_type(model_type, true); 101 dir->set_initial_sync_ended_for_type(model_type, true);
103 } 102 }
104 } 103 }
105 } 104 }
106 } 105 }
107 106
108 } // namespace browser_sync 107 } // namespace browser_sync
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698