Issue 8818005: Use the old handler for low frequency idle notifications.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8818005: Use the old handler for low frequency idle notifications. (Closed)

Created:
9 years ago by ulan

Modified:
9 years ago

Reviewers:
Erik Corry

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Use the old handler for low frequency idle notifications. BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=10179

Patch Set 2 : Restore old checks. #

Total comments: 2

Patch Set 3 : Simplify, fix tests. #

Total comments: 1

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -7 lines)			Patch
M	src/heap.cc	View	1 2	1 chunk	+2 lines, -1 line	0 comments	Download
M	test/cctest/test-api.cc	View	1 2	1 chunk	+0 lines, -4 lines	1 comment	Download
M	test/cctest/test-heap.cc	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

LGTM http://codereview.chromium.org/8818005/diff/2002/src/heap.cc File src/heap.cc (right): http://codereview.chromium.org/8818005/diff/2002/src/heap.cc#newcode4546 src/heap.cc:4546: return hint < 1000 ? true : IdleGlobalGC(); ...

9 years ago (2011-12-06 10:28:34 UTC) #2

ulan

9 years ago (2011-12-06 14:29:09 UTC) #3

Thanks for the suggestion, landing.

http://codereview.chromium.org/8818005/diff/2002/src/heap.cc
File src/heap.cc (right):

http://codereview.chromium.org/8818005/diff/2002/src/heap.cc#newcode4546
src/heap.cc:4546: return hint < 1000 ? true : IdleGlobalGC();
On 2011/12/06 10:28:34, Erik Corry wrote:
> Simpler version:
> 
> if (hint >= 1000) return IdleGlobalGC();
> if (...) {
>   return true;
> }

Done.

http://codereview.chromium.org/8818005/diff/1005/test/cctest/test-api.cc
File test/cctest/test-api.cc (left):

http://codereview.chromium.org/8818005/diff/1005/test/cctest/test-api.cc#oldc...
test/cctest/test-api.cc:13466: CHECK(no_idle_work || new_size < 3 * old_size /
4);
Restoring this test to the state before I added the new idle notification,
otherwise, it flakes.