Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Unified Diff: tools/testing/architecture.py

Issue 8817025: Enable test script to specify different DRT binary (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/architecture.py
diff --git a/tools/testing/architecture.py b/tools/testing/architecture.py
index 96d3bb406161ddeeaf191d79bb0d51f560d0ce44..c9eec5adc12e49d7cedae16e56464255c88c6ce7 100755
--- a/tools/testing/architecture.py
+++ b/tools/testing/architecture.py
@@ -270,17 +270,27 @@ class BrowserArchitecture(Architecture):
def GetRunCommand(self, fatal_static_type_errors=False):
"""Returns a command line to execute for the test."""
fatal_static_type_errors = fatal_static_type_errors # shutup lint!
+ # Find DRT
# For some reason, DRT needs to be called via an absolute path
- drt_location = os.path.join(self.root_path, 'client', 'tests', 'drt',
- 'DumpRenderTree')
+ drt_location = None
+ flags = self.vm_options
+ for flag in flags:
+ if flag.startswith('--browser='):
+ drt_location = flag.split('=')[1]
+ break
+ if drt_location is not None:
+ drt_location = os.path.abspath(drt_location)
+ else:
+ drt_location = os.path.join(self.root_path, 'client', 'tests', 'drt',
+ 'DumpRenderTree')
- # On Mac DumpRenderTree is a .app folder
- if platform.system() == 'Darwin':
- drt_location += '.app/Contents/MacOS/DumpRenderTree'
+ # On Mac DumpRenderTree is a .app folder
+ if platform.system() == 'Darwin':
+ drt_location += '.app/Contents/MacOS/DumpRenderTree'
drt_flags = ['--no-timeout']
dart_flags = '--dart-flags=--enable_asserts --enable_type_checks '
- dart_flags += ' '.join(self.vm_options)
+ dart_flags += ' '.join(flags)
Emily Fortuna 2011/12/06 19:08:19 Out of curiosity, why rename vm_options to the loc
drt_flags.append(dart_flags)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698