Issue 8817015: Remove early NaN/Infinity check in MathPowStub.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8817015: Remove early NaN/Infinity check in MathPowStub. (Closed)

Created:
9 years ago by Yang

Modified:
9 years ago

Reviewers:
ulan

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Remove early NaN/Infinity check in MathPowStub. Committed: http://code.google.com/p/v8/source/detail?r=10172

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : Change comments #

Total comments: 2

Patch Set 5 : switch -0.5 and +0.5 checks #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+94 lines, -88 lines)			Patch
M	src/assembler.cc	View	2	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/ia32/code-stubs-ia32.cc	View	1 2 3 4	2 chunks	+91 lines, -86 lines	0 comments	Download
M	src/runtime.cc	View	1 2 3	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Yang

Please take a look. I removed the early NaN/Infinity check of the base and handle ...

9 years ago (2011-12-06 10:42:56 UTC) #1

ulan

9 years ago (2011-12-06 11:55:19 UTC) #2

LGTM with nits.

http://codereview.chromium.org/8817015/diff/3005/src/ia32/code-stubs-ia32.cc
File src/ia32/code-stubs-ia32.cc (right):

http://codereview.chromium.org/8817015/diff/3005/src/ia32/code-stubs-ia32.cc#...
src/ia32/code-stubs-ia32.cc:3014: // xmm3 now has -0.5.
Typo in the comment xmm3 -> xmm4.

http://codereview.chromium.org/8817015/diff/3005/src/ia32/code-stubs-ia32.cc#...
src/ia32/code-stubs-ia32.cc:3045: // xmm2 now has 0.5.
Typo in the comment xmm2 -> xmm4.

Expand Messages | Collapse Messages