Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 8817014: Add a non-null check for a pointer to NPAPIClient::ExecuteGetJavascriptUrlTest::TimerProc (Closed)

Created:
9 years ago by Timur Iskhodzhanov
Modified:
9 years ago
Reviewers:
ananta
CC:
chromium-reviews, darin-cc_chromium.org, Reid Kleckner, Derek Bruening, zhaoqin1
Visibility:
Public.

Description

Add a non-null check for a pointer to NPAPIClient::ExecuteGetJavascriptUrlTest::TimerProc BUG=106522 TEST=trybot Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114633

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M webkit/plugins/npapi/test/plugin_get_javascript_url_test.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Timur Iskhodzhanov
9 years ago (2011-12-06 11:55:49 UTC) #1
Timur Iskhodzhanov
+cc just FYI
9 years ago (2011-12-06 13:01:12 UTC) #2
Timur Iskhodzhanov
ping?
9 years ago (2011-12-14 11:41:18 UTC) #3
ananta
LGTM
9 years ago (2011-12-14 23:25:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timurrrr@chromium.org/8817014/1
9 years ago (2011-12-15 09:42:49 UTC) #5
commit-bot: I haz the power
Try job failure for 8817014-1 (retry) on mac_rel for step "ui_tests". It's a second try, ...
9 years ago (2011-12-15 12:18:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timurrrr@chromium.org/8817014/1
9 years ago (2011-12-15 13:35:13 UTC) #7
commit-bot: I haz the power
9 years ago (2011-12-15 14:55:32 UTC) #8
Change committed as 114633

Powered by Google App Engine
This is Rietveld 408576698