Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 8817012: Fixing fix for MathPowHalf on ARM. (Closed)

Created:
9 years ago by Yang
Modified:
9 years ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

Fixing fix for MathPowHalf on ARM. Committed: http://code.google.com/p/v8/source/detail?r=10167

Patch Set 1 #

Patch Set 2 : Changed register allocation and also fixed presubmit. #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M src/arm/lithium-arm.cc View 1 2 chunks +5 lines, -2 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 1 chunk +4 lines, -2 lines 0 comments Download
M test/mjsunit/math-pow.js View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Yang
PTAL. Turns out vcmp(DwVfpRegister, double) does not work the way I thought it would and ...
9 years ago (2011-12-06 08:42:22 UTC) #1
Sven Panne
9 years ago (2011-12-06 09:19:12 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698