Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8817010: ntp: remove default thumbnail for most visited (broken camera) (Closed)

Created:
9 years ago by Evan Stade
Modified:
9 years ago
Reviewers:
csilv, Dan Beam
CC:
chromium-reviews, estade+watch_chromium.org, arv (Not doing code reviews)
Visibility:
Public.

Description

ntp: remove default thumbnail for most visited (broken camera) BUG=92421 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113333

Patch Set 1 #

Total comments: 2

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -12 lines) Patch
D chrome/app/theme/default_thumbnail.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/theme_resources.grd View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/ntp4/most_visited_page.css View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/ntp4/new_tab_theme.css View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/ntp/thumbnail_source.cc View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Evan Stade
9 years ago (2011-12-06 06:50:20 UTC) #1
csilv
lgtm
9 years ago (2011-12-06 19:28:40 UTC) #2
Dan Beam
lgtm with nit/question http://codereview.chromium.org/8817010/diff/1/chrome/browser/resources/ntp4/most_visited_page.css File chrome/browser/resources/ntp4/most_visited_page.css (right): http://codereview.chromium.org/8817010/diff/1/chrome/browser/resources/ntp4/most_visited_page.css#newcode100 chrome/browser/resources/ntp4/most_visited_page.css:100: background-size: 100%; Do we have a ...
9 years ago (2011-12-06 19:41:14 UTC) #3
Evan Stade
http://codereview.chromium.org/8817010/diff/1/chrome/browser/resources/ntp4/most_visited_page.css File chrome/browser/resources/ntp4/most_visited_page.css (right): http://codereview.chromium.org/8817010/diff/1/chrome/browser/resources/ntp4/most_visited_page.css#newcode100 chrome/browser/resources/ntp4/most_visited_page.css:100: background-size: 100%; On 2011/12/06 19:41:14, Dan Beam wrote: > ...
9 years ago (2011-12-06 20:17:36 UTC) #4
commit-bot: I haz the power
9 years ago (2011-12-07 00:53:06 UTC) #5

Powered by Google App Engine
This is Rietveld 408576698