Issue 8817005: Revert 113007 - DownloadManager intereface refactoring to allow cleaner DownloadItem unit tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8817005: Revert 113007 - DownloadManager intereface refactoring to allow cleaner DownloadItem unit tests. (Closed)

Created:
9 years ago by not at google - send to devlin

Modified:
9 years ago

Reviewers:
Randy Smith (Not in Mondays)

CC:
chromium-reviews, kkania, jam, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, rdsmith+dwatch_chromium.org, Paweł Hajdan Jr., robertshield

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 113007 - DownloadManager intereface refactoring to allow cleaner DownloadItem unit tests. BUG=101214 Review URL: http://codereview.chromium.org/8697006 TBR=rdsmith@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113084

Patch Set 1 #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+234 lines, -330 lines)			Patch
MM	chrome/browser/automation/testing_automation_provider.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/download/chrome_download_manager_delegate.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/download/download_item_unittest.cc	View	4 chunks	+23 lines, -43 lines	0 comments	Download
MM	chrome/browser/download/download_prefs.h	View	2 chunks	+1 line, -8 lines	0 comments	Download
M	chrome/browser/download/download_prefs.cc	View	2 chunks	+0 lines, -12 lines	0 comments	Download
M	chrome/browser/download/download_shelf_context_menu.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	content/browser/download/download_item.h	View	5 chunks	+2 lines, -12 lines	0 comments	Download
M	content/browser/download/download_item_impl.h	View	5 chunks	+8 lines, -67 lines	0 comments	Download
M	content/browser/download/download_item_impl.cc	View	24 chunks	+36 lines, -61 lines	0 comments	Download
M	content/browser/download/download_manager.h	View	5 chunks	+47 lines, -14 lines	0 comments	Download
M	content/browser/download/download_manager_impl.h	View	7 chunks	+15 lines, -34 lines	0 comments	Download
M	content/browser/download/download_manager_impl.cc	View	15 chunks	+29 lines, -47 lines	0 comments	Download
M	content/browser/download/mock_download_item.h	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	content/browser/download/mock_download_manager.h	View	5 chunks	+13 lines, -9 lines	0 comments	Download
M	content/browser/download/mock_download_manager.cc	View	7 chunks	+45 lines, -12 lines	0 comments	Download
M	content/browser/download/save_package.cc	View	1 chunk	+10 lines, -4 lines	0 comments	Download
M	content/public/browser/download_manager_delegate.h	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages