Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 8817001: Make a gyp file for the pnacl_irt_shim. (Closed)

Created:
9 years ago by jvoung - send to chromium...
Modified:
8 years, 10 months ago
CC:
native-client-reviews_googlegroups.com, pnacl-team_google.com
Visibility:
Public.

Description

Make a gyp file for the pnacl_irt_shim (nacl-side) - Add generated_sources variable to untrusted.gypi to handle sources that are generated and thus unscannable. BUG= http://code.google.com/p/nativeclient/issues/detail?id=2465 TEST= manual - gclient runhooks - run gyp make - check output directory (out/Release/obj/gen/tc_newlib/lib64/) - touch generator python files - run make again to check that it re-ran the generator

Patch Set 1 #

Patch Set 2 : x #

Patch Set 3 : x2 #

Patch Set 4 : x3 #

Patch Set 5 : only x86-64 #

Patch Set 6 : add at least one non-glob input... #

Patch Set 7 : '' #

Patch Set 8 : Fix path issue with globbing #

Patch Set 9 : try quoting the paths to please windows? #

Patch Set 10 : Move one gyp file to chrome #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -0 lines) Patch
M build/all.gyp View 1 2 3 4 5 6 7 8 9 1 chunk +9 lines, -0 lines 0 comments Download
A build/gyp_glob.py View 1 2 3 4 5 6 7 8 9 1 chunk +40 lines, -0 lines 0 comments Download
M build/untrusted.gypi View 1 2 3 4 5 6 7 9 chunks +20 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
noelallen_use_chromium
You could add the step to generate 'C' style .h headers to SHARED_INTERMEDIATE. Then depend ...
9 years ago (2011-12-07 19:20:47 UTC) #1
jvoung - send to chromium...
9 years ago (2011-12-08 22:39:02 UTC) #2
On 2011/12/07 19:20:47, noelallen wrote:
> You could add the step to generate 'C' style .h headers to
SHARED_INTERMEDIATE. 
>  Then depend on that step so that your shim step makes more sense.   (It only
> depends on the header generator step and the *.py files)
> 

Started thinking about how to write the 'action' for generating the headers. The
'inputs' of the action will end up look similar (using gyp_glob.py), since the
headers depend the IDL files + python scripts. The 'outputs' may look a bit
ugly, since we will basically take the list of IDL files and map that list to a
list a headers.

Is there another way?


> The PPAPI headers should be getting moved to this new location so that would
be
> a step in the correct direction.
> 
> The issue is that generating the PPAPI headers (IMO) is a Chrome thing.  So
that
> should happen in the Chrome tree.   That means the SHIM is a Chrome thing and
> should happen in the chrome tree.
> 
> Unfortunately, we do not have a good way of running those GYP pieces in NaCl
> because of the tree hierarchy.   Which really means all this should run only
in
> Chrome.
> 
> Do we need to run this in NaCl?

As we discussed yesterday, there are some commandline toolchain tests that use
sel_universal to mock the file-handle-passing to the sandboxed compilers. These
toolchain tests will still need a shim file since it uses the linker same
"commandline" as it does in the browser, even though the shim file in NaCl may
be stale.

I ended up moving the pnacl_irt_shim.gyp file to the ppapi directory:

http://codereview.chromium.org/8873035/

To get rid of the "add_path_prefix.py" script/hack, since most of the files it
refers to are in the ppapi directory. It also seemed to help with building this
in Windows.

However, splitting up the CL means that I was only able to manually test this...

Powered by Google App Engine
This is Rietveld 408576698