Issue 8816020: More removal of write barriers and a rename to a less scary name.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8816020: More removal of write barriers and a rename to a less scary name. (Closed)

Created:
9 years ago by Erik Corry

Modified:
9 years ago

Reviewers:
Vyacheslav Egorov (Chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

More Reviews

Description

More removal of write barriers and a rename to a less scary name. Committed: http://code.google.com/p/v8/source/detail?r=10186

Patch Set 1 #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+58 lines, -55 lines)			Patch
M	src/heap.cc	View	33 chunks	+36 lines, -36 lines	0 comments	Download
M	src/heap-inl.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/objects.h	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	src/objects.cc	View	7 chunks	+11 lines, -11 lines	0 comments	Download
M	src/objects-inl.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/runtime.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/spaces.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Chromium)

lgtm if it helps but I would prefer a better name than _no_wb. NoWriteBarrierSetMap probably ...

9 years ago (2011-12-06 13:28:52 UTC) #2

Erik Corry

9 years ago (2011-12-07 08:33:33 UTC) #3

On 2011/12/06 13:28:52, Vyacheslav Egorov wrote:
> lgtm if it helps but I would prefer a better name than _no_wb.
> 
> NoWriteBarrierSetMap probably or add SKIP_WRITE_BARRIER argument to the
set_map.

Done (called it set_map_no_write_barrier)

Expand Messages | Collapse Messages