Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(541)

Issue 8816018: Don't build sync_unit_tests for TSan/win (Closed)

Created:
9 years ago by Timur Iskhodzhanov
Modified:
9 years ago
CC:
chromium-reviews, Reid Kleckner, cbentzel
Visibility:
Public.

Description

Don't build sync_unit_tests for TSan/win We don't run it yet it's slow and fails due to too-big PDB files on the bot TBR=glider Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113192

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M build/all.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Timur Iskhodzhanov
9 years ago (2011-12-06 12:54:16 UTC) #1
Timur Iskhodzhanov
+sheriffs
9 years ago (2011-12-06 12:54:41 UTC) #2
Alexander Potapenko
LGTM
9 years ago (2011-12-06 12:55:18 UTC) #3
cbentzel
9 years ago (2011-12-06 13:04:26 UTC) #4
Lgtm

From my smartphone.
On Dec 6, 2011 7:54 AM, <timurrrr@chromium.org> wrote:

> Reviewers: Alexander Potapenko,
>
> Description:
> Don't build sync_unit_tests for TSan/win
> We don't run it yet it's slow and fails due to too-big PDB files on the bot
> TBR=glider
>
> Please review this at
http://codereview.chromium.**org/8816018/<http://codereview.chromium.org/8816...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src/<http://svn.chromium.org/chrome/trunk/src/>
>
> Affected files:
>  M     build/all.gyp
>
>
> Index: build/all.gyp
> ==============================**==============================**=======
> --- build/all.gyp       (revision 113187)
> +++ build/all.gyp       (working copy)
> @@ -488,7 +488,6 @@
>           'type': 'none',
>           'dependencies': [
>             '../base/base.gyp:base_**unittests',
> -            '../chrome/chrome.gyp:sync_**unit_tests',
>             '../content/content.gyp:**content_unittests',
>             '../crypto/crypto.gyp:crypto_**unittests',
>             '../ipc/ipc.gyp:ipc_tests',
>
>
>

Powered by Google App Engine
This is Rietveld 408576698