Issue 8816002: SSLClientSocketNSS::ClearSessionCache should initialize

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8816002: SSLClientSocketNSS::ClearSessionCache should initialize (Closed)

Created:
9 years ago by wtc

Modified:
9 years ago

Reviewers:
mattm

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

SSLClientSocketNSS::ClearSessionCache should initialize NSS implicitly before calling the NSS function SSL_ClearSessionCache. Remove the stale comment that SSLClientSocketNSS::ClearSessionCache is only for tests. R=mattm@chromium.org BUG=105431 TEST=net_unittests --gtest_filter=SSLClientSocketNSSTest.ClearSessionCache Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113125

Patch Set 1 #

Patch Set 2 : Add NET_EXPORT_PRIVATE #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -3 lines)			Patch
M	net/net.gyp	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	net/socket/ssl_client_socket_nss.h	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	net/socket/ssl_client_socket_nss.cc	View		1 chunk	+6 lines, -0 lines	0 comments	Download
A	net/socket/ssl_client_socket_nss_unittest.cc	View		1 chunk	+17 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wtc@chromium.org/8816002/4001

9 years ago (2011-12-06 04:38:28 UTC) #3

Change committed as 113125

Expand Messages | Collapse Messages