Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 8815015: Fix a signed settings serialization issue. (Closed)

Created:
9 years ago by pastarmovj
Modified:
9 years ago
Reviewers:
Ivan Korotkov
CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Fix an signed settings serialization issue. Calling CrosSettings::Set when the DeviseSettingsProvider is in untrusted state on owned device leads to endless loop. Also there was a race condition between storing the signed settings cache and setting values in the signed settings on device owning which might lead to loosing values from the memory cache stored there before the ownership has been acquired. BUG=chromium-os:23805 TEST=See bug description. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113365

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fixed the nit. I will commit it if trybots are happy. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -7 lines) Patch
M chrome/browser/chromeos/device_settings_provider.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/session_manager_observer.cc View 1 1 chunk +6 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/login/signed_settings_cache.cc View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
pastarmovj
Please have a look at this CL it should be fixing the issue plus some ...
9 years ago (2011-12-06 15:21:43 UTC) #1
Ivan Korotkov
9 years ago (2011-12-06 15:30:27 UTC) #2
lgtm

http://codereview.chromium.org/8815015/diff/1/chrome/browser/chromeos/login/s...
File chrome/browser/chromeos/login/session_manager_observer.cc (right):

http://codereview.chromium.org/8815015/diff/1/chrome/browser/chromeos/login/s...
chrome/browser/chromeos/login/session_manager_observer.cc:59: if (success &&
g_browser_process && g_browser_process->local_state()) {
One-line branches don't need braces.

Powered by Google App Engine
This is Rietveld 408576698