Issue 8815014: Add support for recommended settings to the internet details dialog.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8815014: Add support for recommended settings to the internet details dialog. (Closed)

Created:
9 years ago by Mattias Nissler (ping if slow)

Modified:
9 years ago

Reviewers:
stevenjb, James Hawkins

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add support for recommended settings to the internet details dialog. Extend the controlled settings bubble code to allow for an event to be fired upon user request to apply the recommended setting. Handle the recommended case properly for the internet detail dialog by enabling controls for recommended settings and handling resets by restoring the default value in the control. BUG=chromium-os:23124 TEST=Configure recommended settings for a network (currently only AutoConnect is relevant) and check the "Options" dialog for that network. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114624

	Unified diffs	Side-by-side diffs	Stats (+73 lines, -22 lines)			Patch
M	chrome/browser/resources/options/chromeos/internet_detail.js	View	1 chunk	+64 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/options/chromeos/internet_options.js	View	1 chunk	+1 line, -19 lines	0 comments	Download
M	chrome/browser/resources/options/controlled_setting.js	View	2 chunks	+8 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages

Issue 8815014: Add support for recommended settings to the internet details dialog. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : Rebase. #

Messages