Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 8815008: Set default text input type to NONE for NaCl apps on OSX (Closed)

Created:
9 years ago by kochi
Modified:
9 years ago
CC:
chromium-reviews, kinaba
Visibility:
Public.

Description

Set default text input type to NONE for NaCl apps on OSX This is a temporary solution for Lion key-repeat + popup issue. When Pepper IME API is exposed to NaCl apps, each apps should set the text input type apporpriately. BUG=chromium:102808 TEST=Run any NaCl app on Lion and hold 'a' key for a while to see the variant selector popup will not show up. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113571

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M ppapi/native_client/src/trusted/plugin/plugin.cc View 2 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
kochi
Hi Brett, Viet-Trung, Could you review this? This fixes crbug.com/102808, but would like to remove ...
9 years ago (2011-12-06 09:28:02 UTC) #1
kochi
adding David for ppapi/native_client OWNERS. David, if it's inconvenient for you, please route to someone ...
9 years ago (2011-12-07 00:54:30 UTC) #2
viettrungluu
It looks okay to me, but probably someone who's seen this file before should review ...
9 years ago (2011-12-07 05:16:08 UTC) #3
dmichael (off chromium)
Lgtm On Dec 6, 2011 10:16 PM, <viettrungluu@chromium.org> wrote: > It looks okay to me, ...
9 years ago (2011-12-07 05:45:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kochi@chromium.org/8815008/1
9 years ago (2011-12-08 06:37:33 UTC) #5
commit-bot: I haz the power
9 years ago (2011-12-08 07:47:36 UTC) #6
Change committed as 113571

Powered by Google App Engine
This is Rietveld 408576698