Issue 8810001: Fixing a problem in ProfileManager when registering testing profiles and wanting them in the prof...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8810001: Fixing a problem in ProfileManager when registering testing profiles and wanting them in the prof... (Closed)

Created:
9 years ago by jwd

Modified:
9 years ago

Reviewers:
rpetterson, Miranda Callahan, akalin

CC:
chromium-reviews, rginda+watch_chromium.org, achuith+watch_chromium.org

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

More Reviews

Description

Fixing a problem in ProfileManager when registering testing profiles and wanting them in the profile info cache. BUG=106400, 87658 TEST=sync_integration_tests

Patch Set 1 #

Patch Set 2 : =Increasing the value returned by SyncTest::NumberOfDefaultSyncItems() #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	chrome/browser/profiles/profile_manager.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download
	M	chrome/browser/sync/test/integration/sync_test.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Miranda Callahan

9 years ago (2011-12-05 22:11:46 UTC) #2

On 2011/12/05 22:09:19, Jesse Doherty wrote:
> At the moment, I have no idea why the mac sync tests are failing...

I am going to call in Rachel for this review, as she's done a lot of work with
the profile manager during tests recently, and may have an idea as to why this
is failing...

Expand Messages | Collapse Messages