Issue 8808003: aura: Fix file-opening functions in platform_util.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8808003: aura: Fix file-opening functions in platform_util. (Closed)

Created:
9 years ago by Daniel Erat

Modified:
9 years ago

Reviewers:
sky

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

aura: Fix file-opening functions in platform_util. This removes NOTIMPLEMENTED()s for platform_util's ShowItemInFolder(), OpenItem(), and OpenExternal(). We now use the native Chrome OS, Windows, or Linux versions of these functions. BUG=99712 TEST=manual: checked that we use the file manager extension to open downloaded files on Chrome OS and that we use XDG on linux Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113157

Patch Set 1 #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+2 lines, -19 lines)			Patch
M	chrome/browser/platform_util_aura.cc	View	1 chunk	+0 lines, -15 lines	0 comments	Download
M	chrome/browser/platform_util_linux.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/platform_util_win.cc	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	2 chunks	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/8808003/1

9 years ago (2011-12-06 05:22:14 UTC) #3

Change committed as 113157

Expand Messages | Collapse Messages