Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Unified Diff: tests/subprocess2_test.py

Issue 8808002: Using lists is faster than cStringIO. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « subprocess2.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/subprocess2_test.py
diff --git a/tests/subprocess2_test.py b/tests/subprocess2_test.py
index 467d6fb4a5ac5bbf22ba71295dd289325f976330..d9321797b0398396813184601aaed800198710d4 100755
--- a/tests/subprocess2_test.py
+++ b/tests/subprocess2_test.py
@@ -400,6 +400,16 @@ class S2Test(BaseTestCase):
self._check_res(res, None, None, 10)
self._run_test(fn)
+ def test_stdin_empty(self):
+ def fn(c, e, un):
+ stdin = ''
+ res = subprocess2.communicate(
+ e + ['--read'],
+ stdin=stdin,
+ universal_newlines=un)
+ self._check_res(res, None, None, 0)
+ self._run_test(fn)
+
def test_stdin_void(self):
res = subprocess2.communicate(self.exe + ['--read'], stdin=VOID)
self._check_res(res, None, None, 0)
« no previous file with comments | « subprocess2.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698