Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8808002: Using lists is faster than cStringIO. (Closed)

Created:
9 years ago by M-A Ruel
Modified:
9 years ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, Dirk Pranke, M-A Ruel
Visibility:
Public.

Description

Using lists is faster than cStringIO. Clean up stdin management. Remove stale comments. R=dpranke@chromium.org BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113065

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -32 lines) Patch
M subprocess2.py View 4 chunks +30 lines, -32 lines 0 comments Download
M tests/subprocess2_test.py View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
M-A Ruel
9 years ago (2011-12-05 19:40:13 UTC) #1
Dirk Pranke
lgtm
9 years ago (2011-12-05 22:51:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/8808002/1
9 years ago (2011-12-05 23:40:02 UTC) #3
commit-bot: I haz the power
9 years ago (2011-12-05 23:46:45 UTC) #4 
Change committed as 113065

Powered by Google App Engine
This is Rietveld 408576698