chrome/browser/automation/ui_controls_aurax11.cc - Issue 8808001: Aura: Convert keysym to kyeycode when posting XKeyEvent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/automation/ui_controls_aurax11.cc

Issue 8808001: Aura: Convert keysym to kyeycode when posting XKeyEvent (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/automation/ui_controls_aurax11.cc

diff --git a/chrome/browser/automation/ui_controls_aurax11.cc b/chrome/browser/automation/ui_controls_aurax11.cc

index 1ab2747e85b7e13e33c3d6f6595a9d35e120c71f..d7dbe697961a6101e6581ae520d0ed0b11fb2ba4 100644

--- a/chrome/browser/automation/ui_controls_aurax11.cc

+++ b/chrome/browser/automation/ui_controls_aurax11.cc

@@ -133,7 +133,9 @@ bool SendKeyPressNotifyWhenDone(gfx::NativeWindow window,

SetMaskAndKeycodeThenSend(&xevent, ShiftMask, XK_Shift_L);

if (alt)

SetMaskAndKeycodeThenSend(&xevent, Mod1Mask, XK_Alt_L);

- xevent.xkey.keycode = ui::XKeysymForWindowsKeyCode(key, shift);

+ xevent.xkey.keycode =

+ XKeysymToKeycode(base::MessagePumpX::GetDefaultXDisplay(),

Daniel Erat 2011/12/05 19:40:38 we should also be calling XRefreshKeyboardMapping(

+ ui::XKeysymForWindowsKeyCode(key, shift));

aura::Desktop::GetInstance()->PostNativeEvent(&xevent);

// Send key release events.

« no previous file with comments | « no previous file | no next file » | no next file with comments »