Aura: Convert keysym to kyeycode when posting XKeyEvent

Aura: Convert keysym to kyeycode when posting XKeyEvent

BUG=104396
TEST=more tests passes in interactive_ui_tests passes on aura


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113092

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113262

[Daniel Erat, 2011-12-05 19:40:38]

http://codereview.chromium.org/8808001/diff/1/chrome/browser/automation/ui_co...
File chrome/browser/automation/ui_controls_aurax11.cc (right):

http://codereview.chromium.org/8808001/diff/1/chrome/browser/automation/ui_co...
chrome/browser/automation/ui_controls_aurax11.cc:137:
XKeysymToKeycode(base::MessagePumpX::GetDefaultXDisplay(),
we should also be calling XRefreshKeyboardMapping() in response to certain
MappingNotify events, which I don't think we're doing currently:
http://tronche.com/gui/x/xlib/utilities/keyboard/XRefreshKeyboardMapping.html

[Daniel Erat, 2011-12-05 20:39:35]

LGTM after a comment is addressed

http://codereview.chromium.org/8808001/diff/3002/ui/aura/desktop_host_linux.cc
File ui/aura/desktop_host_linux.cc (right):

http://codereview.chromium.org/8808001/diff/3002/ui/aura/desktop_host_linux.c...
ui/aura/desktop_host_linux.cc:471: XRefreshKeyboardMapping(&xev->xmapping);
nit: i think that this should be:

if (xev->xmapping.request == MappingModifier ||
    xev->xmapping.request == MappingKeyboard) {
  XRefreshKeyboardMapping(&xev->xmapping);
}

(you don't need to call this for MappingPointer)

[oshima, 2011-12-05 20:57:27]

http://codereview.chromium.org/8808001/diff/3002/ui/aura/desktop_host_linux.cc
File ui/aura/desktop_host_linux.cc (right):

http://codereview.chromium.org/8808001/diff/3002/ui/aura/desktop_host_linux.c...
ui/aura/desktop_host_linux.cc:471: XRefreshKeyboardMapping(&xev->xmapping);
On 2011/12/05 20:39:36, Daniel Erat wrote:
> nit: i think that this should be:
> 
> if (xev->xmapping.request == MappingModifier ||
>     xev->xmapping.request == MappingKeyboard) {
>   XRefreshKeyboardMapping(&xev->xmapping);
> }
> 
> (you don't need to call this for MappingPointer)

Done.

[commit-bot: I haz the power, 2011-12-05 20:58:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/oshima@chromium.org/8808001/3004

[commit-bot: I haz the power, 2011-12-05 20:58:21]

Presubmit check for 8808001-3004 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for: ui/aura/desktop_host_linux.cc

Presubmit checks took 1.1s to calculate.

[oshima, 2011-12-05 21:04:57]

On 2011/12/05 20:58:21, I haz the power (commit-bot) wrote:
> Presubmit check for 8808001-3004 failed and returned exit status 1.
> 
> Running presubmit commit checks ...
> 
> ** Presubmit ERRORS **
> Missing LGTM from an OWNER for: ui/aura/desktop_host_linux.cc
> 
> Presubmit checks took 1.1s to calculate.

Dan, may I separate desktop_host_linux.cc to another CL?

[commit-bot: I haz the power, 2011-12-05 22:45:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/oshima@chromium.org/8808001/9001

[commit-bot: I haz the power, 2011-12-06 02:37:43]

Change committed as 113092