Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 8807001: History: Fix regression - unable to remove entries from search results. (Closed)

Created:
9 years ago by Patrick Dubroy
Modified:
9 years ago
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

History: Fix regression - unable to remove entries from search results. In the switchover from history2, the ability to select multiple history search results (using the checkboxes) was lost. This CL restores that ability, and fixes some style issues with the search results page. BUG=106394 TEST=Manual: open chrome://history, do a search, and ensure that you can select and delete multiple items. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113044

Patch Set 1 #

Total comments: 1

Patch Set 2 : Use -webkit-clamp-line instead. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -2 lines) Patch
M chrome/browser/resources/history.css View 1 2 chunks +14 lines, -1 line 0 comments Download
M chrome/browser/resources/history.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Patrick Dubroy
Hi Erik, Can you please review this? Since it fixes a regression in history page ...
9 years ago (2011-12-05 15:04:47 UTC) #1
arv (Not doing code reviews)
9 years ago (2011-12-05 18:52:39 UTC) #2
LGTM

http://codereview.chromium.org/8807001/diff/1/chrome/browser/resources/histor...
File chrome/browser/resources/history.css (right):

http://codereview.chromium.org/8807001/diff/1/chrome/browser/resources/histor...
chrome/browser/resources/history.css:101: max-height: 3.2em;  /* Two lines max.
*/
-webkit-line-clamp: 2;

http://dropshado.ws/post/1015351370/webkit-line-clamp

Powered by Google App Engine
This is Rietveld 408576698