Issue 88070: Add -DCHROME_V8 to the chrome/browser build....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 88070: Add -DCHROME_V8 to the chrome/browser build.... (Closed)

Created:
11 years, 8 months ago by sgk

Modified:
9 years, 5 months ago

Reviewers:
Mark Mentovai

CC:
chromium-reviews_googlegroups.com, Michael Moss

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Add -DCHROME_V8 to the chrome/browser build. Add a 'javascript_engine' variable to control that setting (as well as whether we use v8.gyp at all). Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=14171

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+27 lines, -4 lines)			Patch
M	build/all.gyp	View	1 chunk	+5 lines, -1 line	0 comments	Download
M	build/common.gypi	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/chrome.gyp	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	net/net.gyp	View	2 chunks	+5 lines, -1 line	0 comments	Download
M	webkit/webkit.gyp	View	3 chunks	+8 lines, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

Mark Mentovai

11 years, 8 months ago (2009-04-22 00:40:20 UTC) #3

LGTM (as long as the trybots like it).  This is exactly how it was designed to
fit together, nice!