Issue 8806034: Enable pepper flash by default in windows canary

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8806034: Enable pepper flash by default in windows canary (Closed)

Created:
9 years ago by cpu_(ooo_6.6-7.5)

Modified:
9 years ago

Reviewers:
brettw

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Enable pepper flash by default in windows canary - Enabled by default for new versions of the plugin - Now it does not auto-disable if enabled BUG=89248 TEST=see bug Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113266

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -10 lines)			Patch
	M	chrome/browser/component_updater/pepper_flash_component_installer.cc	View	1	6 chunks	+27 lines, -10 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

brettw

9 years ago (2011-12-06 01:34:47 UTC) #2

lgtm

http://codereview.chromium.org/8806034/diff/1/chrome/browser/component_update...
File chrome/browser/component_updater/pepper_flash_component_installer.cc
(right):

http://codereview.chromium.org/8806034/diff/1/chrome/browser/component_update...
chrome/browser/component_updater/pepper_flash_component_installer.cc:93:
std::wstring channel;
Can you use string16 for new code?

http://codereview.chromium.org/8806034/diff/1/chrome/browser/component_update...
chrome/browser/component_updater/pepper_flash_component_installer.cc:184: if
(fresh_install)
Need {}

Expand Messages | Collapse Messages