Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Unified Diff: compiler/java/com/google/dart/compiler/backend/js/JavascriptBackend.java

Issue 8806032: Prevent "complete" file from being cached across compilation sessions to save space (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: '' Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: compiler/java/com/google/dart/compiler/backend/js/JavascriptBackend.java
===================================================================
--- compiler/java/com/google/dart/compiler/backend/js/JavascriptBackend.java (revision 2085)
+++ compiler/java/com/google/dart/compiler/backend/js/JavascriptBackend.java (working copy)
@@ -30,6 +30,8 @@
*/
public class JavascriptBackend extends AbstractJsBackend {
+ public static final String EXTENSION_APP_JS_COMPLETE = EXTENSION_APP_JS + ".complete";
+
/**
* Wraps an Appendable and keeps track of the current offset as line/columns.
*/
@@ -162,7 +164,7 @@
String completeArtifactName = EXTENSION_APP_JS;
if (hasEntryPoint) {
// Apps with entry points will be reduced so we write into a different file name
- completeArtifactName = "complete." + EXTENSION_APP_JS;
+ completeArtifactName = EXTENSION_APP_JS_COMPLETE;
}
Writer out = context.getArtifactWriter(app, "", completeArtifactName);
@@ -179,7 +181,6 @@
if (hasEntryPoint) {
- Reader artifactReader = context.getArtifactReader(app, "", completeArtifactName);
Writer artifactWriter = context.getArtifactWriter(app, "", EXTENSION_APP_JS);
try {
failed = true;
@@ -187,7 +188,6 @@
failed = false;
} finally {
Closeables.close(artifactWriter, failed);
- Closeables.close(artifactReader, failed);
}
}

Powered by Google App Engine
This is Rietveld 408576698