Add commands to Chrome WebDriver for installing and manipulating extensions.

Add commands to custom Chrome WebDriver for installing and manipulating extensions.
BUG=93571
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113726

[Huyen, 2011-12-08 02:10:31]

http://codereview.chromium.org/8806030/diff/9008/chrome/test/automation/autom...
File chrome/test/automation/automation_json_requests.cc (right):

http://codereview.chromium.org/8806030/diff/9008/chrome/test/automation/autom...
chrome/test/automation/automation_json_requests.cc:804: *error_msg = "Extension
uninstall not permitted";
is there any chance this can also mean the uninstall failed somehow?

http://codereview.chromium.org/8806030/diff/9008/chrome/test/webdriver/comman...
File chrome/test/webdriver/commands/chrome_commands.cc (right):

http://codereview.chromium.org/8806030/diff/9008/chrome/test/webdriver/comman...
chrome/test/webdriver/commands/chrome_commands.cc:104: // Path:
"/session/$id/chrome/extension/$id".
is the second path variable the session id? maybe change $id to $session_id.

http://codereview.chromium.org/8806030/diff/9008/chrome/test/webdriver/comman...
chrome/test/webdriver/commands/chrome_commands.cc:200: 
delete newline

http://codereview.chromium.org/8806030/diff/9008/chrome/test/webdriver/comman...
chrome/test/webdriver/commands/chrome_commands.cc:210: 
delete newline

http://codereview.chromium.org/8806030/diff/9008/chrome/test/webdriver/comman...
File chrome/test/webdriver/commands/chrome_commands.h (right):

http://codereview.chromium.org/8806030/diff/9008/chrome/test/webdriver/comman...
chrome/test/webdriver/commands/chrome_commands.h:79: virtual void
ExecuteGet(Response* const response) OVERRIDE;
maybe add comments stating this method gets all the current views?

http://codereview.chromium.org/8806030/diff/9008/chrome/test/webdriver/webdri...
File chrome/test/webdriver/webdriver_automation.cc (right):

http://codereview.chromium.org/8806030/diff/9008/chrome/test/webdriver/webdri...
chrome/test/webdriver/webdriver_automation.cc:774: false /* allow_in_incognito
*/, &error_msg))
do we assume the extension is never allow_in_incognito? what if it current state
does allow_in_incognito?

[kkania, 2011-12-08 17:31:20]

http://codereview.chromium.org/8806030/diff/9008/chrome/test/automation/autom...
File chrome/test/automation/automation_json_requests.cc (right):

http://codereview.chromium.org/8806030/diff/9008/chrome/test/automation/autom...
chrome/test/automation/automation_json_requests.cc:804: *error_msg = "Extension
uninstall not permitted";
On 2011/12/08 02:10:32, Huyen wrote:
> is there any chance this can also mean the uninstall failed somehow?

No, if you look at NOTIFICATION_EXTENSION_UNINSTALL_NOT_ALLOWED in
automation_provider_observers.cc, it only sets success to false in this case.

http://codereview.chromium.org/8806030/diff/9008/chrome/test/webdriver/comman...
File chrome/test/webdriver/commands/chrome_commands.cc (right):

http://codereview.chromium.org/8806030/diff/9008/chrome/test/webdriver/comman...
chrome/test/webdriver/commands/chrome_commands.cc:104: // Path:
"/session/$id/chrome/extension/$id".
On 2011/12/08 02:10:32, Huyen wrote:
> is the second path variable the session id? maybe change $id to $session_id.

Done.

http://codereview.chromium.org/8806030/diff/9008/chrome/test/webdriver/comman...
chrome/test/webdriver/commands/chrome_commands.cc:200: 
On 2011/12/08 02:10:32, Huyen wrote:
> delete newline

Done.

http://codereview.chromium.org/8806030/diff/9008/chrome/test/webdriver/comman...
chrome/test/webdriver/commands/chrome_commands.cc:210: 
On 2011/12/08 02:10:32, Huyen wrote:
> delete newline

Done.

http://codereview.chromium.org/8806030/diff/9008/chrome/test/webdriver/comman...
File chrome/test/webdriver/commands/chrome_commands.h (right):

http://codereview.chromium.org/8806030/diff/9008/chrome/test/webdriver/comman...
chrome/test/webdriver/commands/chrome_commands.h:79: virtual void
ExecuteGet(Response* const response) OVERRIDE;
On 2011/12/08 02:10:32, Huyen wrote:
> maybe add comments stating this method gets all the current views?

Done.

http://codereview.chromium.org/8806030/diff/9008/chrome/test/webdriver/webdri...
File chrome/test/webdriver/webdriver_automation.cc (right):

http://codereview.chromium.org/8806030/diff/9008/chrome/test/webdriver/webdri...
chrome/test/webdriver/webdriver_automation.cc:774: false /* allow_in_incognito
*/, &error_msg))
On 2011/12/08 02:10:32, Huyen wrote:
> do we assume the extension is never allow_in_incognito? what if it current
state
> does allow_in_incognito?

I decided not to support setting an extension in incognito mode for now. It's
not allowed in incognito by default and I don't allow the user to enable it via
webdriver.

[Huyen, 2011-12-08 18:36:59]

lgtm

[commit-bot: I haz the power, 2011-12-08 19:29:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kkania@chromium.org/8806030/19001

[commit-bot: I haz the power, 2011-12-08 23:08:04]

Try job failure for 8806030-19001 (retry) (previous was lost) on mac_rel for
steps "browser_tests, ui_tests".
It's a second try, previously, steps "net_unittests, browser_tests, ui_tests"
failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2011-12-08 23:16:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kkania@chromium.org/8806030/19001

[commit-bot: I haz the power, 2011-12-09 01:30:33]

Change committed as 113726