Issue 8806027: Commit CL for kmixter: http://codereview.chromium.org/8788006

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8806027: Commit CL for kmixter: http://codereview.chromium.org/8788006 (Closed)

Created:
9 years ago by Charlie Lee

Modified:
9 years ago

Reviewers:
kmixter1

CC:
chromium-reviews, pam+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Commit CL for kmixter: http://codereview.chromium.org/8788006 BUG=chromium-os:23476 TBR=kmixter@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113051

Patch Set 1 #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	tools/cros.DEPS/DEPS	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

kmixter1

9 years ago (2011-12-05 22:59:12 UTC) #2

LGTM

On Mon, Dec 5, 2011 at 2:58 PM,  <chocobo@chromium.org> wrote:
> Reviewers: kmixter1,
>
> Description:
> Commit CL for kmixter: http://codereview.chromium.org/8788006
> BUG=chromium-os:23476
> TBR=kmixter@chromium.org
>
> Please review this at http://codereview.chromium.org/8806027/
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
>  M     tools/cros.DEPS/DEPS
>
>
> Index: tools/cros.DEPS/DEPS
> ===================================================================
> --- tools/cros.DEPS/DEPS        (revision 112963)
> +++ tools/cros.DEPS/DEPS        (working copy)
> @@ -7,6 +7,6 @@
>     "src/third_party/cros":
>       Var("chromiumos_git") + "/platform/cros.git@63b0d1fd",
>     "src/third_party/cros_system_api":
> -      Var("chromiumos_git") + "/platform/system_api.git@b999aceb",
> +      Var("chromiumos_git") + "/platform/system_api.git@bb265e37",
>   }
>  }
>
>
>

Expand Messages | Collapse Messages